fix(copilotcli): update elicitation handler in copilot cli to use ask tool#309446
Merged
DonJayamanne merged 1 commit intomainfrom Apr 14, 2026
Merged
fix(copilotcli): update elicitation handler in copilot cli to use ask tool#309446DonJayamanne merged 1 commit intomainfrom
DonJayamanne merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Copilot CLI session/MCP integration so the MCP gateway can be started with a session-associated URI (instead of an always-random URI), aligning MCP tool-call context with the originating chat session.
Changes:
- Extend
ICopilotCLIMCPHandler.loadMcpConfigto accept asessionUriand forward it toIMcpService.startMcpGateway. - Update
CopilotCLISessionServiceto pass a session-derived URI into MCP config loading for both session creation and session resume. - Adjust CLI test helpers to match the updated MCP handler interface.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/copilotcli/node/test/testHelpers.ts | Updates the null MCP handler stub to accept a resource/URI parameter. |
| extensions/copilot/src/extension/chatSessions/copilotcli/node/mcpHandler.ts | Threads a session URI through MCP config loading and into startMcpGateway. |
| extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts | Provides a session-derived URI to loadMcpConfig when creating/resuming CLI sessions. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts
Show resolved
Hide resolved
ulugbekna
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307962